[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

Med Ismail Bennani via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 29 12:26:13 PST 2023


================
@@ -1402,22 +1402,24 @@ void Debugger::SetDestroyCallback(
 static void PrivateReportProgress(Debugger &debugger, uint64_t progress_id,
                                   std::string title, std::string details,
                                   uint64_t completed, uint64_t total,
-                                  bool is_debugger_specific) {
+                                  bool is_debugger_specific,
+                                  uint32_t is_aggregate) {
----------------
medismailben wrote:

nit: I'd use the enum type here instead of the `uint32_t`
```suggestion
                                  ProgressReportType report_type) {
```

https://github.com/llvm/llvm-project/pull/69516


More information about the lldb-commits mailing list