[Lldb-commits] [lldb] [LLDB] Add more helper functions to CompilerType class (second try). (PR #73472)

Felipe de Azevedo Piovezan via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 29 08:17:24 PST 2023


================
@@ -436,8 +482,8 @@ class CompilerType {
                      ExecutionContextScope *exe_scope);
 
   /// Dump to stdout.
-  void DumpTypeDescription(lldb::DescriptionLevel level =
-                           lldb::eDescriptionLevelFull) const;
----------------
felipepiovezan wrote:

I could be wrong here, but AFAICT the bot should _only_ check for formatting changes inside the diff of the commit, not inside the entire file. If this is not what the bot is doing, it is something we can probably improve upon.

In the meantime though, my suggestion is to manually inspect the bot output: if it is complaining about lines not touched by this commit, just ignore that. This is favorable to editing lines that are not related to the patch

https://github.com/llvm/llvm-project/pull/73472


More information about the lldb-commits mailing list