[Lldb-commits] [lldb] [lldb][progress] Always report progress upon Progress object destruction (PR #73605)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Chelsea Cassanova (chelcassanova)

<details>
<summary>Changes</summary>

This commit allows a final progress report upon the destruction of the `Progress` object to happen at all times as opposed to when the progress was not completed.

---
Full diff: https://github.com/llvm/llvm-project/pull/73605.diff


1 Files Affected:

- (modified) lldb/source/Core/Progress.cpp (+1-1) 


``````````diff
diff --git a/lldb/source/Core/Progress.cpp b/lldb/source/Core/Progress.cpp
index 08be73f1470f349..eee4d3955154ba9 100644
--- a/lldb/source/Core/Progress.cpp
+++ b/lldb/source/Core/Progress.cpp
@@ -32,8 +32,8 @@ Progress::~Progress() {
   std::lock_guard<std::mutex> guard(m_mutex);
   if (!m_completed) {
     m_completed = m_total;
-    ReportProgress();
   }
+  ReportProgress();
 }
 
 void Progress::Increment(uint64_t amount, std::string update) {

``````````

</details>


https://github.com/llvm/llvm-project/pull/73605