[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 15 09:41:21 PST 2023


https://github.com/JDevlieghere approved this pull request.

LGTM with a few nits. I like "constituents". 

This is a pretty big patch which makes reviewing it challenging. I know it's a big change that touches a lot of things but I'm sure that this could've been broken up into smaller patches if you keep that goal in mind from the beginning. Something to look out for in the future. 

https://github.com/llvm/llvm-project/pull/68845


More information about the lldb-commits mailing list