[Lldb-commits] [lldb] Centralize the code that figures out which memory ranges to save into core files (PR #71772)

[Greg Clayton via lldb-commits]

clayborg wrote:

> Hello @clayborg ! Looks like this patch broke lldb-aarch64-windows bot: https://lab.llvm.org/buildbot/#/builders/219/builds/6868 Could you please look at this ?

@antmox 

I looked at this and I didn't touch anything related to native windows core file saving. If this is a native windows build on arm64 for lldb, and we are debugging with COFF files, then this code will get run:
```
bool ObjectFilePECOFF::SaveCore(const lldb::ProcessSP &process_sp,
                                const lldb_private::FileSpec &outfile,
                                lldb::SaveCoreStyle &core_style,
                                lldb_private::Status &error) {
  core_style = eSaveCoreFull;
  return SaveMiniDump(process_sp, outfile, error);
}
```
The `SaveMinidump` calls native windows APIs to create the minidump file in `lldb/source/Plugins/ObjectFile/PECOFF/WindowsMiniDump.cpp`. Then this file gets loaded by the ProcessMinidump.cpp and I didn't touch anything inside of the process plug-in that loads the minidumps. So I am not sure how to proceed other than disabling this test for arm64 windows? Does anyone have access to an arm64 windows machine to see what is going on? In theory none of the code I changed should touch this, and I didn't modify `lldb/test/API/functionalities/postmortem/minidump/TestMiniDump.py` at all with this patch.

https://github.com/llvm/llvm-project/pull/71772