[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

[David Spickett via lldb-commits]

=?utf-8?q?José?= L. Junior <josejunior at 10xengineers.ai>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/69422 at github.com>


DavidSpickett wrote:

> For all 3 API command test, the error is same i.e.,
>
> AssertionError: 'error: Couldn't look up symbols:
>  std::deque<Foo, std::allocator<Foo>>::size() const
> ' is not success

This feels like a version problem. Perhaps the libstdc++ on your system isn't the same version as the `-dev` package you installed?

Beyond that, it's hard to say without having a machine in front of me, and is probably not worth the time to figure out. I hate to say it, but I'd just make a note of these failing tests and make sure there aren't more failing tests when your changes are present.

> error: Failed to save core file for process: no ObjectFile plugins were able to save a core for this process
' did not return successfully

I can't see any reason this should fail, so again, make note of it for later.

> Not sure if we are missing some other dependencies to pass these tests (plus isn't there any file which mention these required dependencies? Would have been much more easier 🙂).

You might have needed `build-essential`. This is listed in https://lldb.llvm.org/resources/build.html#optional-dependencies but also we call it optional which isn't great.

More broadly the llvm project has been thinking about docker images to tackle this sort of thing. If you had an Arm64 machine, you could use Linaro's, but we don't run builders on x86 unfortunately.

> Also there are a lot of unsupported tests as well on our system. Is this an issue as well?

Unsupported is stuff like must be running BSD, must have this program installed, etc, so this is not a problem unless every single test was being marked unsupported. Like on Windows, it's normal to have a few 100 unsupported.

So yeah, it's not ideal, but make a note of what failed and then compare with your changes. If it's the same failures, you're fine (I don't think that what you're changing could break those tests anyway).

https://github.com/llvm/llvm-project/pull/69422