[Lldb-commits] [lldb] [lldb] Replace some register handling asserts with lldbassert (PR #71175)
Jonas Devlieghere via lldb-commits
lldb-commits at lists.llvm.org
Mon Nov 6 11:10:32 PST 2023
JDevlieghere wrote:
> These asserts are testing that the static representation of register contexts is ok and building and testing with asserts enabled should flush out any issues. `lldbassert()` is perfect for this since it is enabled for debug builds while testing happens.
The [contributing guidelines](https://lldb.llvm.org/resources/contributing.html) say:
> New code should not be using lldbassert() and existing uses should be replaced by other means of error handling.
This was added (and last discussed) in https://reviews.llvm.org/D59911. It seems like there's enough different opinions on this topic that might warrant a proper RFC.
https://github.com/llvm/llvm-project/pull/71175
More information about the lldb-commits
mailing list