[Lldb-commits] [lldb] [lldb] Part 1 of 2 - Refactor `CommandObject::Execute(...)` return `void` (not `bool`) (PR #69989)

Dave Lee via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 23 21:12:39 PDT 2023


================
@@ -429,11 +428,12 @@ llvm::StringRef CommandObjectProxy::GetUnsupportedError() {
   return "command is not implemented";
 }
 
-bool CommandObjectProxy::Execute(const char *args_string,
+void CommandObjectProxy::Execute(const char *args_string,
                                  CommandReturnObject &result) {
   CommandObject *proxy_command = GetProxyCommandObject();
-  if (proxy_command)
-    return proxy_command->Execute(args_string, result);
+  if (proxy_command) {
+    proxy_command->Execute(args_string, result);
----------------
kastiglione wrote:

seems there should be a `return` after this line, which I presume you meant to add, since you added parens.

https://github.com/llvm/llvm-project/pull/69989


More information about the lldb-commits mailing list