[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

[via lldb-commits]

jimingham wrote:

I don't understand how this helps.  You can't write DWARF (or other lldb plugins) w/o both exporting the API that those plugins are supposed to implement (which should properly go in the `plugins` namespace whatever we call it), but also all of other API's in lldb_private that come along for the ride.  

So if you want to make an external plug-in that uses lldb's private plugin making machinery, you're going to have to export more than just what would be in the "plugin API" per se.  So I don't think you really gain anything by putting it at the top level.

And if we do come up with a supported API for plugins, lldb_plugins is the most obvious name for the API, so I'd like not to commandeer that for this purpose if we can avoid it.

Jim


> On Oct 16, 2023, at 4:52 PM, Greg Clayton ***@***.***> wrote:
> 
> 
> And if we ever make external plug-ins, they wouldn't be expected to use either the "lldb_private::plugins" or "lldb_plugins" namespaces as those are solely for built in stuff.
> 
> —
> Reply to this email directly, view it on GitHub <https://github.com/llvm/llvm-project/pull/68150#issuecomment-1765443159>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUPVW54YOSZRVOK4QF66FLX7XCFVAVCNFSM6AAAAAA5RQL3PWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRVGQ2DGMJVHE>.
> You are receiving this because you commented.
> 



https://github.com/llvm/llvm-project/pull/68150