[Lldb-commits] [lldb] [lldb-vscode] Allow specifying a custom escape character for LLDB commands (PR #69238)

[Alex Langford via lldb-commits]

bulbazord wrote:

> With "lldb-vscode" (which might be "lldb-dap" soon) being a native DAP plug-in, I believe this means we can't set settings in the IDE itself if we are not a typescript DAP plug-in.
> 
> How would anyone specify this extra option when running lldb-vscode? Is there a way to specify extra options that "lldb-vscode" should be launched with from the VS Code GUI? If so, how does this work? Or are you using this from a different IDE other than VS Code that allows you to specify extra options?
> 
> The optimal solution for this in my mind would be to have some global settings that we can set in the VS Code GUI. I know there can be plug-in specific setting set as we allow a path to be specified in a custom DAP plug-in that points to the path to the "lldb-vscode" binary to actaully run instead of the one in the extensions folder. But I don't know if this can be done with a native only DAP plug-in (our custom solution has a typescript wrapper that eventually spawns "lldb-vscode" as we need to intercept and fix some packets, so we actaully have a typescript as our main DAP plug-in and we forward packets to lldb-vscode).
> 
> The other way to fix this would be to add this as a launch config option. @walter-erquinigo this is how you did a previous fix for auto variable summaries being enabled.
> 
> So we should really figure out our solution to having global settings and do them all consistently.

There doesn't seem to be an actual standard 'LLDB' plugin in the VSCode plugin marketplace. Since they all could work differently, it makes sense to me that we add customization at the `lldb-dap` layer so that the VSCode plugins can handle this however they want. Specifically, a plugin could add a setting to customize what the escape character is and then have it launch `lldb-dap` with that setting. Hopefully I understood your point? I'm not sure it makes sense for us to be able to add a global VSCode setting since this setting will only be used when interacting with `lldb-dap`.

https://github.com/llvm/llvm-project/pull/69238