[Lldb-commits] [lldb] [lldb][AArch64] Add isAArch64SMEFA64 check to SME testing (PR #68094)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 6 06:00:54 PDT 2023


DavidSpickett wrote:

I ran all the tests that originally had `isAArch64SME` in, on an FVP without smefa64 and added checks as needed. But I did not make note of the unchanged ones at the time, so I've redone that and added it to the commit message.

The ffr use you specifically noticed, the tests use isAArch64SMEFA64 up front and skip if it's not there. Then later when they want an SVCR value they just use isAArch64SME since strictly that's all that bit needs to know.

We could just have isAArch64SMEFA64 everywhere even if we didn't really need smefa64, but I figured it would be nice to have as many tests run in either situation as we can (for my benefit more than anything else right now).

https://github.com/llvm/llvm-project/pull/68094


More information about the lldb-commits mailing list