[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

Wed Sep 20 16:27:42 PDT 2023

dblaikie added a comment.

In D157609#4645298 <https://reviews.llvm.org/D157609#4645298>, @clayborg wrote:

> In D157609#4644194 <https://reviews.llvm.org/D157609#4644194>, @DavidSpickett wrote:
>
>>> Any chance we could simplify this situation and have dwo searches use exactly the same/shared logic as source file searches?
>>
>> I'm not sure what exactly this means, can you clarify?
>>
>> I know that DWP and DWO have different search functions, that could certainly be unified. Not sure how source files work.
>
> Source file search paths and debug info search paths are different in LLDB. GDB had one setting IIRC that handled both. These settings have been in LLDB for a while so I wouldn't recommend changing this up at this point.

I don't think that's a great motivation to diverge them further.

We could make the DWO search fallback to the source search - and add new features to the source search if needed. That'd at least align things a bit closer, rather than diverging further.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157609/new/

https://reviews.llvm.org/D157609