[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

[David Spickett via Phabricator via lldb-commits]

DavidSpickett marked 2 inline comments as done.
DavidSpickett added inline comments.


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181
+
+  return {};
+}
----------------
DavidSpickett wrote:
> omjavaid wrote:
> > Shouldnt we build a relevant error message here incase ReadSMEControl fails on ReadZAHeader
> I think this should be `return error` in fact, let me check what that does.
I now return the underlying error so it won't fail silently.


================
Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_save_restore/TestZARegisterSaveRestore.py:183
+            self.expect("register read svcr", substrs=["0x{:016x}".format(svcr_value)])
 
         for expr in exprs:
----------------
DavidSpickett wrote:
> omjavaid wrote:
> > should we also add a svcr write test here? 
> It's read only. We could allow writes but it introduces a lot more ways to change state, most of which aren't obviously useful for the user. If someone really wants it, it can be added.
> 
> I will note this in a comment here.
I've actually added comments to the other file, where it makes more sense that you might be writing to svcr.

Here the whole test is about having the program setup the registers, and modify them. So there's less expectation that you'd check writing here.

The fact that SVCR is read only (as is SVG) will be documented in fully https://github.com/llvm/llvm-project/pull/66767.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154927/new/

https://reviews.llvm.org/D154927