[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda added inline comments.


================
Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:135
+    process_sp->SetCanInterpretFunctionCalls(true);
+    process_sp->SetCanJIT(false);
+  }
----------------
These should not be set in the ABI, please remove these.  These are probably correct for the qemu environment you're testing against, but if we're connected to a remote stub that can allocate memory (_M packet), we can JIT code. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159101/new/

https://reviews.llvm.org/D159101