[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

Tue Sep 19 01:59:26 PDT 2023

DavidSpickett marked 2 inline comments as done.
DavidSpickett added inline comments.

================
Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/Makefile:3
+
+CFLAGS_EXTRAS := -march=armv8-a+sve+sme -lpthread
+
----------------
DavidSpickett wrote:
> omjavaid wrote:
> > is USE_SSVE a subset of sve+sme? 
> It's a define I made up for the purposes of the test, it's in the existing tests but not well documented. I'll push something to address that in the existing tests and check the new ones here for this and other defines I've added.
> 
> We need sve to update sve registers and sme to be able to move into the za register (/the rows of the za register).
https://github.com/llvm/llvm-project/commit/91f46ece9efca7a1109b5837a1b24f2a251bb0cc

USE_SSVE and friends are just defines `-D...` made up for specific tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159505/new/

https://reviews.llvm.org/D159505