[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

[Jason Molenda via lldb-commits]

================
@@ -6,11 +6,7 @@
 ) lldb::SBWatchpointOptions::SetWatchpointTypeRead;
 %feature("docstring", "Gets whether the watchpoint should stop on read accesses."
 ) lldb::SBWatchpointOptions::GetWatchpointTypeRead;
-%feature("docstring", "Sets whether the watchpoint should stop on write accesses."
+%feature("docstring", "Sets whether the watchpoint should stop on write accesses. eWatchpointWriteTypeOnModify is the most commonly useful mode, where lldb will stop when the watched value has changed. eWatchpointWriteTypeAlways will stop on any write to the watched region, and on some targets there can false watchpoint stops where memory near the watched region was written, and lldb cannot detect that it is a spurious stop."
----------------
jasonmolenda wrote:

(and the "modify" watchpoint type solves both of these, because we can only report watchpoint hits where the watched memory region changes)

https://github.com/llvm/llvm-project/pull/66308