[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

[Muhammad Omair Javaid via Phabricator via lldb-commits]

omjavaid added a comment.

This looks find just couple of nits inline.



================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:354
+
+      // ZA is part of the SME set but uses a seperate member buffer for storage.
+      // Therefore its effective byte offset is always 0 even if it isn't 0 within
----------------
this block of code requires clang-format run


================
Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h:117
 
+  struct sme_regs {
+    uint64_t svg_reg;
----------------
should we name this to sme_pseudo_regs ? sme_regs suggests struct could include ZA as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159503/new/

https://reviews.llvm.org/D159503