[Lldb-commits] [lldb] [lldb] Add 'modify' type watchpoints, make it default (PR #66308)

[Jason Molenda via lldb-commits]

================
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const ExecutionContext &exe_ctx) {
   return (m_new_value_sp && m_new_value_sp->GetError().Success());
 }
 
+bool Watchpoint::WatchedValueReportable(const ExecutionContext &exe_ctx) {
+  if (!m_watch_modify)
+    return true;
+  if (!m_type.IsValid())
+    return true;
+
+  ConstString watch_name("$__lldb__watch_value");
----------------
jasonmolenda wrote:

I  originally did it that way with them in mind!  But I call ValueObject::CreateConstantValue with it a little bit later, and that takes a ConstString.  I didn't chase it further to see if the ValueObject really couldn't allocate storage for a copy of the name.

https://github.com/llvm/llvm-project/pull/66308