[Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

[David Spickett via lldb-commits]

> I would never never write Python code that ugly.

As usual with formatting the conclusions were as long as the same strange
decisions are made consistently, it's worth doing.

Discussion:
https://discourse.llvm.org/t/python-code-style-and-reformatting-status-update/70641/13
Overall project docs:
https://llvm.org/docs/CodingStandards.html#python-version-and-source-code-formatting

Github PRs will also check formatting, but it's not a blocking check.

lldb has the  "the style is llvm but also not" page:
https://lldb.llvm.org/resources/contributing.html. Which hasn't felt the
need to mention clang-format either, so it wouldn't be any worse not
mentioning this.

The llvm page links to black's github which starts with how to install it.
Could do with a one liner to format the changes from the last commit ala
clang-format-diff.

Also we should link to llvm's standards from our page, I'll fix that.

On Tue, 12 Sept 2023 at 17:13, Jim Ingham <jingham at apple.com> wrote:

> Is there any chance we can use something other than black.  I would never
> never write Python code that ugly.
>
> Jim
>
>
> > On Sep 12, 2023, at 8:47 AM, Adrian Prantl via lldb-commits <
> lldb-commits at lists.llvm.org> wrote:
> >
> >
> > adrian-prantl wrote:
> >
> > Have (should we) we documented that we format all python code with black
> somewhere and how to install the tool?
> >
> > https://github.com/llvm/llvm-project/pull/66053
> > _______________________________________________
> > lldb-commits mailing list
> > lldb-commits at lists.llvm.org
> > https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230913/ece994c7/attachment.html>