[Lldb-commits] [PATCH] D159408: Switch over to using the LLVM archive parser for BSD archives.

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Sep 5 10:14:35 PDT 2023


JDevlieghere added a comment.

Overall this looks good, but instead of consuming all the errors, let's log them with `LLDB_LOG_ERROR`. Note that the API is a bit tricky and still requires you to provide a format string:

  LLDB_LOG_ERROR(GetLog(LLDBLog::Object), something.takeError(), "context before printing the actual error: {0}");


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159408/new/

https://reviews.llvm.org/D159408



More information about the lldb-commits mailing list