[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Aug 29 11:44:47 PDT 2023


mib added a comment.

In D158833#4625775 <https://reviews.llvm.org/D158833#4625775>, @bulbazord wrote:

> Re-organizing the paths seems okay to me, especially since this is going to grow further. I think the header guards are going to need some adjustment though.

TBH, I didn't even know they were guidelines wrt header guards 😅

For long file names, I've been using this pattern in the past of separating the words by `_` in the header guards, which also makes it more readable.

I don't think that causes any harm but if you feel strongly about it I can change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158833/new/

https://reviews.llvm.org/D158833



More information about the lldb-commits mailing list