[Lldb-commits] [PATCH] D157063: [CodeGen] Make the MachineFunctionSplitter pass testable via MIR

Daniel Hoekwater via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 28 16:14:18 PDT 2023


dhoekwater updated this revision to Diff 554091.
dhoekwater added a comment.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Try to replace with main to get this to work


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157063/new/

https://reviews.llvm.org/D157063

Files:
  lldb/test/API/commands/settings/TestSettings.py
  lldb/test/Shell/Settings/TestSettingsSet.test


Index: lldb/test/Shell/Settings/TestSettingsSet.test
===================================================================
--- lldb/test/Shell/Settings/TestSettingsSet.test
+++ lldb/test/Shell/Settings/TestSettingsSet.test
@@ -14,7 +14,7 @@
 
 settings set -f tab-size
 settings show tab-size
-# CHECK: tab-size (unsigned) = 4
+# CHECK: tab-size (unsigned) = 2
 
 settings set tab-size
 # CHECK: error: 'settings set' takes more arguments
Index: lldb/test/API/commands/settings/TestSettings.py
===================================================================
--- lldb/test/API/commands/settings/TestSettings.py
+++ lldb/test/API/commands/settings/TestSettings.py
@@ -6,10 +6,11 @@
 import json
 import os
 import re
+
 import lldb
+from lldbsuite.test import lldbutil
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
-from lldbsuite.test import lldbutil
 
 
 class SettingsCommandTestCase(TestBase):
@@ -777,7 +778,7 @@
         # Change a single boolean value.
         self.runCmd("settings set auto-confirm true")
         # Change a single integer value.
-        self.runCmd("settings set tab-size 2")
+        self.runCmd("settings set tab-size 4")
 
         # Clear everything.
         self.runCmd("settings clear --all")
@@ -792,7 +793,7 @@
             patterns=["^target.run-args \(arguments\) =\s*$"],
         )
         self.expect("settings show auto-confirm", substrs=["false"])
-        self.expect("settings show tab-size", substrs=["4"])
+        self.expect("settings show tab-size", substrs=["2"])
 
         # Check that the command fails if we combine '--all' option with any arguments.
         self.expect(
@@ -931,13 +932,13 @@
 
         # Test basic values and embedding special JSON escaping characters.
         self.runCmd("settings set auto-confirm true")
-        self.runCmd("settings set tab-size 2")
+        self.runCmd("settings set tab-size 4")
         arg_value = 'hello "world"'
         self.runCmd("settings set target.arg0 %s" % arg_value)
 
         settings_json = self.get_setting_json()
         self.assertEqual(settings_json["auto-confirm"], True)
-        self.assertEqual(settings_json["tab-size"], 2)
+        self.assertEqual(settings_json["tab-size"], 4)
         self.assertEqual(settings_json["target"]["arg0"], arg_value)
 
         settings_data = self.get_setting_json("target.arg0")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157063.554091.patch
Type: text/x-patch
Size: 2378 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230828/5e494ce4/attachment-0001.bin>


More information about the lldb-commits mailing list