[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.
David Spickett via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Aug 23 01:51:50 PDT 2023
DavidSpickett added inline comments.
================
Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:260-266
+ // the dynamic loader. The problem happens as soon as the executable or
+ // shared library that exports another "_r_debug" is loaded by the dynamic
+ // loader due to the way symbols are found using the shared library search
+ // paths will mean that the new copy takes precedence over the one in the
+ // dynamic loader and the dynamic loader will be updating the other copy
+ // somewhere else that we won't find and that copy will have the
+ // eConsistent state.
----------------
DavidSpickett wrote:
> Can we split this sentence just for readability? Bullet points of each step might be clearer.
What you have in the commit message basically.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158583/new/
https://reviews.llvm.org/D158583
More information about the lldb-commits
mailing list