[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added inline comments.


================
Comment at: lldb/source/Core/Mangled.cpp:61
 
+  // Swift's older style of mangling used "_T" as a mangling prefix. This can
+  // lead to false positives with other symbols that just so happen to start
----------------
Feel free to completely ignore this, it's a pointless micro optimization.

I'm curious if it would be more efficient to write this as 

```
switch (name[0]) {
  case '?':     return Mangled::eManglingSchemeMSVC;
  case '_': 
     switch(name[1]) {
        ...
     }
  case '$': 
     switch(name[1]) {
        ...
     }
```
or if it would actually be slower than the chain of "vector" comparisons we have right now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158470/new/

https://reviews.llvm.org/D158470