[Lldb-commits] [lldb] 949d4d1 - [lldb] Replace radar link with documenting comment (NFC)

[Jonas Devlieghere via lldb-commits]

Author: Jonas Devlieghere
Date: 2023-07-30T14:28:29-07:00
New Revision: 949d4d16027a5829066046db74abcd7e8b31804c

URL: https://github.com/llvm/llvm-project/commit/949d4d16027a5829066046db74abcd7e8b31804c
DIFF: https://github.com/llvm/llvm-project/commit/949d4d16027a5829066046db74abcd7e8b31804c.diff

LOG: [lldb] Replace radar link with documenting comment (NFC)

This replaces the radar link with a comment explaining the underlying
problem, which is that when the (dynamic) type of an object changes, so
does their synthetic filter of choice, which requires us to regenerate
the filter.

Added: 
    

Modified: 
    lldb/source/Core/ValueObjectSyntheticFilter.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Core/ValueObjectSyntheticFilter.cpp b/lldb/source/Core/ValueObjectSyntheticFilter.cpp
index ad29d36ae08a08..b91acbc053593d 100644
--- a/lldb/source/Core/ValueObjectSyntheticFilter.cpp
+++ b/lldb/source/Core/ValueObjectSyntheticFilter.cpp
@@ -163,8 +163,8 @@ bool ValueObjectSynthetic::UpdateValue() {
     return false;
   }
 
-  // regenerate the synthetic filter if our typename changes
-  // <rdar://problem/12424824>
+  // Regenerate the synthetic filter if our typename changes. When the (dynamic)
+  // type of an object changes, so does their synthetic filter of choice.
   ConstString new_parent_type_name = m_parent->GetTypeName();
   if (new_parent_type_name != m_parent_type_name) {
     LLDB_LOGF(log,