[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 28 15:23:22 PDT 2023


bulbazord added a comment.

In D156562#4543743 <https://reviews.llvm.org/D156562#4543743>, @jasonmolenda wrote:

> This is fine to me but maybe instead of `ifndef apple` we could do a `if __has_include(<uuid/uuid.h>)` and include the system header if it's avail.

One reason I decided not to do this is because I don't want to accidentally pull in a different `uuid.h` on other platforms that may have an incompatible `uuid_t` definition. I'm not sure what other definition it may have that would make it incompatible, but it might be a headache to figure that out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156562/new/

https://reviews.llvm.org/D156562



More information about the lldb-commits mailing list