[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Mon Jul 24 10:41:57 PDT 2023

aprantl added inline comments.

================
Comment at: lldb/include/lldb/Target/Platform.h:479
+    /// to an internal SDK
+    bool found_internal_sdk = false;
+
----------------
These flags really only make sense in the context of an XcodeSDK, so why not just return an XcodeSDK or XcodeSDK::Info object here? Otherwise we'll probably introduce subtle bugs due to a lossy translation between the flags.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156020/new/

https://reviews.llvm.org/D156020