[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

Med Ismail Bennani via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 21 16:45:05 PDT 2023


mib updated this revision to Diff 543122.
mib marked 3 inline comments as done.
mib added a comment.

Address @JDevlieghere last comments.

- Use `unique_ptr` instead of `shared_ptr` for PIMPL
- Add missing new line after instrumentation macros
- Move `ScriptObject` from `Utility` to `Interpreter`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155161/new/

https://reviews.llvm.org/D155161

Files:
  lldb/bindings/headers.swig
  lldb/bindings/interface/SBScriptObjectExtensions.i
  lldb/bindings/interfaces.swig
  lldb/bindings/python/python-typemaps.swig
  lldb/include/lldb/API/SBDebugger.h
  lldb/include/lldb/API/SBDefines.h
  lldb/include/lldb/API/SBProcess.h
  lldb/include/lldb/API/SBScriptObject.h
  lldb/include/lldb/API/SBStructuredData.h
  lldb/include/lldb/Core/StructuredDataImpl.h
  lldb/include/lldb/Interpreter/ScriptInterpreter.h
  lldb/include/lldb/Interpreter/ScriptObject.h
  lldb/include/lldb/lldb-types.h
  lldb/source/API/CMakeLists.txt
  lldb/source/API/SBProcess.cpp
  lldb/source/API/SBScriptObject.cpp
  lldb/source/API/SBStructuredData.cpp
  lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
  lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
  lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h
  lldb/test/API/python_api/sbstructureddata/TestStructuredDataAPI.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D155161.543122.patch
Type: text/x-patch
Size: 21618 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230721/98370e89/attachment-0001.bin>


More information about the lldb-commits mailing list