[Lldb-commits] [PATCH] D154617: [lldb][DebugNamesDWARF] Also use mangled name when matching regex

Felipe de Azevedo Piovezan via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 6 13:02:47 PDT 2023


fdeazeve added a comment.

In D154617#4478369 <https://reviews.llvm.org/D154617#4478369>, @JDevlieghere wrote:

> Is the reason this is necessary because the apple accelerator tables would emit an entry for both the mangled and demangled name?

Not quite. The name inside the accelerator table (Apple or DWARF 5) is always mangled.
So if we want a user to be able to do `frame var --regex A::`, the only way this can possibly work is if we demangle the table entry prior to matching against the regex. This is what the test mentioned in the commit message is testing.

In the implementation of `AppleDWARFIndex.cpp`, we also do this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154617/new/

https://reviews.llvm.org/D154617



More information about the lldb-commits mailing list