[Lldb-commits] [PATCH] D154532: [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jul 5 11:18:16 PDT 2023


JDevlieghere added a comment.

In D154532#4474534 <https://reviews.llvm.org/D154532#4474534>, @bulbazord wrote:

> These uses of `LLDB_LOG` are taking errors, consuming them while turning them into strings, and logging them. Unless I'm missing something, I think it would make more sense to convert these to use `LLDB_LOG_ERROR`.

Good point, I blindly fixed the format specifiers without lookin what was being passed in.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154532/new/

https://reviews.llvm.org/D154532



More information about the lldb-commits mailing list