[Lldb-commits] [PATCH] D153626: [lldb] Use SmallVector for handling register data

[David Spickett via Phabricator via lldb-commits]

DavidSpickett added reviewers: omjavaid, JDevlieghere, labath.
DavidSpickett added a comment.

This assumes that the usual use case is:

- Make a small vector.
- Resize it to what you need.
- Use the content like an array.

Every case I found matched that but still, it's not the safest API ever. So I've tested this on arm64 of course, and did try to run the test suite with asan but issues with leaks in Python prevented that. No amount of filtering seemed to help.

I see Green Dragon runs an lldb sanitizers bot, so my plan would be to rely on that to catch any tricky issues prior to any SME changes going in.



================
Comment at: lldb/include/lldb/Utility/RegisterValue.h:36
+    // Anything else we'll heap allocate storage for it.
+    kMaxRegisterByteSize = kTypicalRegisterByteSize,
+  };
----------------
When the ZA register is added, this will change to 256*256. For now nothing should change apart from the slight overhead of SmallVector.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153626/new/

https://reviews.llvm.org/D153626