[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

Fangrui Song via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 2 14:37:14 PDT 2023


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

If `nonMicrosoftDemangle` is going to be changed to take a `string_view` argument, adding `if (!MangledName) return false;` should be fine.
If possible, it's best for the change to be deferred to a later patch on the stack, but I won't push strongly on this. You did the work...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151003/new/

https://reviews.llvm.org/D151003



More information about the lldb-commits mailing list