[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

Michael Buch via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 31 08:47:27 PDT 2023


Michael137 accepted this revision.
Michael137 added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lldb/source/Core/ValueObjectSyntheticFilter.cpp:338
   if (!did_find && m_synth_filter_up != nullptr) {
     uint32_t index = m_synth_filter_up->GetIndexOfChildWithName(name);
     if (index == UINT32_MAX)
----------------
Could pass name_ref directly now, instead of doing the implicit conversion


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151811/new/

https://reviews.llvm.org/D151811



More information about the lldb-commits mailing list