[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

[Aman LaChapelle via Phabricator via lldb-commits]

bzcheeseman added inline comments.


================
Comment at: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h:30
 
-  LLVMCastKind getKind() const { return m_kind; }
-
-  ExpressionTypeSystemHelper(LLVMCastKind kind) : m_kind(kind) {}
-
-  ~ExpressionTypeSystemHelper() = default;
-
-protected:
-  LLVMCastKind m_kind;
+  virtual bool isA(const void *ClassID) const = 0;
 };
----------------
I was expecting you'd just use `RTTIExtends` from Support/ExtensibleRTTI.h, any reason not to use that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150303/new/

https://reviews.llvm.org/D150303