[Lldb-commits] [PATCH] D150363: [lldb][nfc] Simplify DebugRanges class

Shubham Sandeep Rastogi via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 11 10:30:19 PDT 2023


rastogishubham added inline comments.


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:32
 
-  typedef std::map<dw_offset_t, DWARFRangeList> range_map;
-  typedef range_map::iterator range_map_iterator;
-  typedef range_map::const_iterator range_map_const_iterator;
-  range_map m_range_map;
+  std::map<dw_offset_t, DWARFRangeList> m_range_map;
 };
----------------
fdeazeve wrote:
> rastogishubham wrote:
> > Any reason why the name was changed to `m_range_map`?
> It was also `m_range_map` before. Maybe you're confusing it with name of the typedef that got deleted? The diff highlighting here is misleading
Yes you are right, I got a bit confused there, sorry


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150363/new/

https://reviews.llvm.org/D150363



More information about the lldb-commits mailing list