[Lldb-commits] [PATCH] D149987: ObjectFile: introduce a COFF object file plugin

[Saleem Abdulrasool via Phabricator via lldb-commits]

compnerd marked 4 inline comments as done.
compnerd added inline comments.


================
Comment at: lldb/source/Plugins/ObjectFile/COFF/ObjectFileCOFF.cpp:203
+            .Case(".debug_pubnames", eSectionTypeDWARFDebugPubNames)
+            .Case(".debug_pubtypes", eSectionTypeDWARFDebugPubTypes)
+            .Case(".debug_str", eSectionTypeDWARFDebugStr)
----------------
aprantl wrote:
> Can these be correct? They seem too long.
They do exceed the COFF limit of 8 characters.  However, this is what is actually emitted with a tweak to indicate the long name.  This is why I cannot simply use the `Section->Name` and need to extract the long name through the generic `SectionRef`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149987/new/

https://reviews.llvm.org/D149987