[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

Tue May 2 16:20:55 PDT 2023

wallace added inline comments.

================
Comment at: lldb/include/lldb/lldb-enumerations.h:493
   eLanguageTypeAda2012 = 0x002f,
+  eLanguageTypeMojo = 0x0030,

----------------
aprantl wrote:
> bulbazord wrote:
> > These values correspond to DWARF5's official language codes and `0x0030` is technically already taken. LLDB just hasn't been updated yet. I don't think this should necessarily block this patch but this value will need to be changed at some point.
> > 
> > See: https://dwarfstd.org/languages.html
> Registering a new language with the DWARF committee is a pretty quick process nowadays. Please do that before taking a constant in the reserved range.
Thanks for the information. I'll do so then :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149702/new/

https://reviews.llvm.org/D149702