[Lldb-commits] [lldb] 76fb334 - [lldb] Remove TestExternalEditor.test

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Mon May 1 21:26:40 PDT 2023


Author: Jonas Devlieghere
Date: 2023-05-01T21:25:14-07:00
New Revision: 76fb3343029ea618c0cc14d1b20f82b7941cff5e

URL: https://github.com/llvm/llvm-project/commit/76fb3343029ea618c0cc14d1b20f82b7941cff5e
DIFF: https://github.com/llvm/llvm-project/commit/76fb3343029ea618c0cc14d1b20f82b7941cff5e.diff

LOG: [lldb] Remove TestExternalEditor.test

Remove TestExternalEditor.test as the code to open the transcript in an
external editor is conditional on lldb running in a graphical session.
As a result this test passes locally but not on the bots.

Added: 
    

Modified: 
    

Removed: 
    lldb/test/Shell/Settings/TestExternalEditor.test


################################################################################
diff  --git a/lldb/test/Shell/Settings/TestExternalEditor.test b/lldb/test/Shell/Settings/TestExternalEditor.test
deleted file mode 100644
index de0195ae8ac5..000000000000
--- a/lldb/test/Shell/Settings/TestExternalEditor.test
+++ /dev/null
@@ -1,4 +0,0 @@
-REQUIRES: system-darwin
-RUN: %lldb -o 'settings set use-external-editor true' -o 'setting set external-editor foo' -o 'session save' -b 2>&1 | FileCheck %s
-RUN: LLDB_EXTERNAL_EDITOR="foo" %lldb -o 'settings set use-external-editor true' -o 'session save' -b 2>&1 | FileCheck %s
-CHECK: error: could not find external editor "foo": LSFindApplicationForInfo returned error


        


More information about the lldb-commits mailing list