[Lldb-commits] [PATCH] D149472: [lldb] Refactor host::OpenFileInExternalEditor

[Med Ismail Bennani via Phabricator via lldb-commits]

mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.

LGTM with some comments



================
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:335
+
+  const std::string file_path = file_spec.GetPath();
+
----------------
I guess this doesn't need to be a `const std::string`, a `llvm::StringRef` would have been nice but looking at `SBFileSpec::GetPath`, there is unfortunately no overload for that.


================
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:385
 
-  static std::string g_app_name;
-  static FSRef g_app_fsref;
+  static std::optional<FSRef> g_app_fsref;
+  static std::once_flag g_once_flag;
----------------
why is this static ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149472/new/

https://reviews.llvm.org/D149472