[Lldb-commits] [PATCH] D149472: [lldb] Refactor host::OpenFileInExternalEditor

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, bulbazord, mib.
Herald added a project: All.
JDevlieghere requested review of this revision.

This patch refactors the macOS implementation of `OpenFileInExternalEditor`:

- Fix `AppleEvent` memory leak
- Fix caching of `LLDB_EXTERNAL_EDITOR`
- Fix (speculatively) crash when CFURL is NULL.
- Improve readability
- Improve documentation
- Improve logging

rdar://108633464


https://reviews.llvm.org/D149472

Files:
  lldb/source/Host/macosx/objcxx/Host.mm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149472.517989.patch
Type: text/x-patch
Size: 5639 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230428/ad1e25d7/attachment-0001.bin>