[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael Buch via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 27 05:38:30 PDT 2023


Michael137 accepted this revision.
Michael137 added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/DW_OP_div-with-signed.s:3
+
+  # RUN: %clang --target=x86_64-pc-linux -o %t %s
+  # RUN: %lldb %t -o "b f" -o "r" -o "c" -o "c" -o "expression -T -- i" \
----------------
other tests use `llvm-mc` as the assembler
E.g., `llvm-mc -filetype=obj -o %t -triple x86_64-pc-linux %s`

I think it'll marginally speed things up


================
Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/DW_OP_div-with-signed.s:6
+  # RUN: -o "exit" | FileCheck %s
+
+  # Failing case was:
----------------
Can you paste the source code here which you used to derive this test case? For future readers


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147370/new/

https://reviews.llvm.org/D147370



More information about the lldb-commits mailing list