[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 26 12:48:23 PDT 2023


bulbazord created this revision.
bulbazord added a reviewer: jasonmolenda.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

FileSpec::GetFileNameExtension returns a string where the first
character is guaranteed to be a `'.'`. This was probably just an
oversight during a refactor.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149284

Files:
  lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp


Index: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
===================================================================
--- lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
+++ lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
@@ -482,7 +482,7 @@
     bool recurse) {
   static ConstString g_kext_suffix = ConstString(".kext");
   static ConstString g_dsym_suffix = ConstString(".dSYM");
-  static ConstString g_bundle_suffix = ConstString("Bundle");
+  static ConstString g_bundle_suffix = ConstString(".Bundle");
 
   FileSpec file_spec(path);
   ConstString file_spec_extension = file_spec.GetFileNameExtension();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149284.517272.patch
Type: text/x-patch
Size: 656 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230426/7dd25fab/attachment.bin>


More information about the lldb-commits mailing list