[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 26 11:29:44 PDT 2023


bulbazord requested changes to this revision.
bulbazord added inline comments.
This revision now requires changes to proceed.


================
Comment at: lldb/source/Expression/LLVMUserExpression.cpp:339
+      if (stack_frame_size == 0)
+        stack_frame_size = arch == llvm::Triple::msp430 ? 512 : 512 * 1024;
 
----------------
jingham wrote:
> This doesn't seem appropriate in generic code.  You should ask the Arch plugin for this.
Oh, I missed this in the previous patch. Yeah, we shouldn't be hardcoding `llvm::Triple::msp430` in generic code. You're introducing even more uses of this in this patch, we should abstract this out into a plugin like Jim suggested.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149262/new/

https://reviews.llvm.org/D149262



More information about the lldb-commits mailing list