[Lldb-commits] [PATCH] D149111: [lldb] Add support for specifying language when setting watchpoint by expression

Tue Apr 25 16:16:56 PDT 2023

mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.

In D149111#4296709 <https://reviews.llvm.org/D149111#4296709>, @bulbazord wrote:

> In D149111#4296670 <https://reviews.llvm.org/D149111#4296670>, @mib wrote:
>
>> I think we should still be able to use this new flag with the previous ones (i.e. `watchpoint set -l c++ -w read -- &my_var`)
>
> You can do that still with this patch. I'm placing the language flag in a 2nd group so that `watchpoint set variable` does not have access to this flag, but `watchpoint set expression` does. You can still mix and match the flags for `expression`.

Thanks for clarifying that. LGTM!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149111/new/

https://reviews.llvm.org/D149111