[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

[Med Ismail Bennani via Phabricator via lldb-commits]

mib added a comment.

In D148399#4274470 <https://reviews.llvm.org/D148399#4274470>, @JDevlieghere wrote:

> I think a lot of this can be simplified by using `LLDB_LOG` instead of `LLDB_LOGF`.



In D148399#4275219 <https://reviews.llvm.org/D148399#4275219>, @bulbazord wrote:

> +1 to what Jonas said. `LLDB_LOG` would greatly simplify this since it puts `__FILE__` and `__func__` in each message, which is what these are doing manually.

@bulbazord @JDevlieghere I don't think using using `LLDB_LOG` instead of `LLDB_LOGF` would be of any use here, because we're interested because that will just say we're in `Process::func`. What we care about here is to know which process plugin calling that function, so I still have to pass `GetPluginName` as an argument.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148399/new/

https://reviews.llvm.org/D148399