[Lldb-commits] [PATCH] D145574: [lldb] Read register fields from target XML

[David Spickett via Phabricator via lldb-commits]

DavidSpickett marked an inline comment as done.
DavidSpickett added inline comments.


================
Comment at: lldb/include/lldb/lldb-private-types.h:14
 
+#include "lldb/Target/RegisterFlags.h"
 #include "lldb/lldb-private.h"
----------------
MaskRay wrote:
> Is there a library layering violation?
> 
> I assume that `lldb/Target/*.h` files depend on `lldb/include/lldb/lldb-private-types.h`, so `lldb/include/lldb/lldb-private-types.h` cannot include `lldb/Target/*.h` files...
It is and thanks for the fix!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145574/new/

https://reviews.llvm.org/D145574