[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

Fri Apr 14 07:20:10 PDT 2023

Michael137 marked an inline comment as not done.
Michael137 added inline comments.

================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:551
   case lldb::eLanguageTypeC_plus_plus_14:
     lang_opts.CPlusPlus11 = true;
     m_compiler->getHeaderSearchOpts().UseLibcxx = true;
----------------
Michael137 wrote:
> aprantl wrote:
> > Why does this not set C++14? Because it's effectively equivalent?
> I think it's because we haven't done the work to make c++14 in the expression evaluator work, but the default clang language is c++14. So we downgrade it silently to c++11 here.
> 
> We should really fix that, but I think this broke some tests in the past when we tried enabling it (see `8cb75745412e4bc9592d2409cc6cfa4a2940d9e7`, https://reviews.llvm.org/D80308)
But looking at the specific test failures from back then there doesn't seem like a good reason for why we can't re-enable that patch now. And also add a C++17 version.

Let me try that

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143062/new/

https://reviews.llvm.org/D143062