[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

[Jorge Gorbe Moya via Phabricator via lldb-commits]

jgorbe updated this revision to Diff 512272.
jgorbe marked 3 inline comments as done.
jgorbe added a comment.

Addressed review comments.

- Use `lldb::pid_t` instead of unsigned long, and `LLDB_INVALID_PROCESS_ID` instead of `0` in the cases where the PID is missing.
- Only pass the `--debugger-pid` flag if we're on Linux and we have a debugger PID. I don't think we need to be particularly lenient with flag parsing, because IIUC the command lines for the launcher should only ever be built by lldb-vscode itself and not by hand, but it can be confusing for users in other platforms to see `--debugger-pid 0` in the command line on the terminal.
- Changed parsing of the `--debugger-pid` numeric value to use `llvm::StringRef`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147805/new/

https://reviews.llvm.org/D147805

Files:
  lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/lldbvscode_testcase.py
  lldb/test/API/tools/lldb-vscode/runInTerminal/TestVSCode_runInTerminal.py
  lldb/tools/lldb-vscode/JSONUtils.cpp
  lldb/tools/lldb-vscode/JSONUtils.h
  lldb/tools/lldb-vscode/Options.td
  lldb/tools/lldb-vscode/lldb-vscode.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D147805.512272.patch
Type: text/x-patch
Size: 8743 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20230410/e7e588d4/attachment.bin>