[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

Sat Apr 8 13:02:31 PDT 2023

jasonmolenda added a comment.

In D147833#4253416 <https://reviews.llvm.org/D147833#4253416>, @jasonmolenda wrote:

> idk maybe I'm over-thinking it, but this does make me a little uncomfortable.  We have at least one instance where someone did `platform_sp->GetPluginName() == "ios-simulator"` in ClangExpressionSourceCode.cpp

I only looked around for the first instance of this code pattern, there may be another place where we compare identification strings from objects.  And I don't feel confident that I can anticipate what will be added to lldb in the future.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147833/new/

https://reviews.llvm.org/D147833