[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

LU Hongyi via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 5 18:38:12 PDT 2023


jwnhy added a comment.

In D147606#4246832 <https://reviews.llvm.org/D147606#4246832>, @JDevlieghere wrote:

> The change looks fine and regardless of whether this makes sense or even complies with the standard, we should be resilient against it. I would like to see a test though.

Thanks a lot for the comment, I am new to lldb community, and got one thing a bit silly to ask.
Up to now, a few patches I submitted is kind of "depending on the compiler-generated" binary?
What am I supposed to do to **ensure the compiler generates these "easy-to-fault" binaries in the test?**

Like in this one, not every compiler will generate "empty ranges", and in the other one that is "DW_OP_div"...

I would like to add tests once I figure these out...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147606/new/

https://reviews.llvm.org/D147606



More information about the lldb-commits mailing list